[ 
https://issues.apache.org/jira/browse/S2GRAPH-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097869#comment-15097869
 ] 

ASF GitHub Bot commented on S2GRAPH-9:
--------------------------------------

GitHub user daewon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/8

    [S2GRAPH-9] Provide rest server using netty

    This issue dependence on S2GRAPH-7 (Abstract common code)
    
    I made Http server using Netty and S2Graph
    
    S2Graph provide CRUD operation, 
    but now, read operations were completed
    
    1. Make http rest server using netty
    2. Attach s2core to netty server and refactoring some s2rest_play's 
controllers using `RestHandler`
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daewon/incubator-s2graph 
s2graph-9_add_netty_server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 5980bf7fd2b1a5977c5badca2400cb4a08d042b8
Author: daewon <[email protected]>
Date:   2016-01-14T09:03:20Z

    S2GRAPH-7 Move PostProcess.scala to s2core from root project

commit 4dfebc767f83d2056dcd90b1539ffcad750ee158
Author: daewon <[email protected]>
Date:   2016-01-05T06:07:20Z

    S2GRAPH-7 Move RequestParser from Root to s2core

commit 9f16c00a251c395e2b393932359edd18481a3a35
Author: daewon <[email protected]>
Date:   2016-01-14T09:09:27Z

    S2GRAPH-7 Make RestCaller for abstract over http layer

commit 7453aebf0ddd47d93ac68e1ca027923978aef235
Author: daewon <[email protected]>
Date:   2016-01-14T09:11:06Z

    S2GRAPH-7 Move root project to s2rest_play

commit 32b1c4a8b38c22053ac2863d8948708d8bd03a0d
Author: daewon <[email protected]>
Date:   2016-01-14T09:13:02Z

    S2GRAPH-7 Move Test from root to s2core

commit 8b3ddf64cc47e9270cfbe0d4295a5f590e05186c
Author: daewon <[email protected]>
Date:   2016-01-14T09:13:29Z

    S2GRAPH-7 Apply review by SteamShon

commit 964bbc4988ab4e84b7efe6f6fdcc8be9a0e1ee7c
Author: daewon <[email protected]>
Date:   2016-01-06T09:19:54Z

    S2GRAPH-9 Provide rest server using netty

commit 57d7b45619ea9d9834fbf7f191abe7c9929a38bd
Author: daewon <[email protected]>
Date:   2016-01-06T09:31:53Z

    mend

commit f533ebf24b0c79132b1e914f5d349b01fb20ffd4
Author: daewon <[email protected]>
Date:   2016-01-06T09:39:26Z

    Revmoe unused config

commit c79fa0326febaa25616aed577e04750bd80308d9
Author: daewon <[email protected]>
Date:   2016-01-07T02:11:30Z

    S2GRAPH-9 add missing config

commit 92112de53ab6eccb896c2d79cc7c06835618987e
Author: daewon <[email protected]>
Date:   2016-01-07T05:30:01Z

    S2GRAPH-9 Refactoring RestCaller -> RestHandler

----


> Provide rest server using netty
> -------------------------------
>
>                 Key: S2GRAPH-9
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-9
>             Project: S2Graph
>          Issue Type: Sub-task
>            Reporter: DOYUNG YOON
>            Assignee: Daewon Jeong
>            Priority: Minor
>              Labels: project_structure, refactoring
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> I benchmarked with netty and it has much better performance with much less 
> resources on query. since faster query means a lot, I think it would be 
> better to add query rest server base on netty. also by implementing query 
> server on different framework, we can find which codes are common and which 
> are server framework specific.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to