[
https://issues.apache.org/jira/browse/S2GRAPH-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097877#comment-15097877
]
ASF GitHub Bot commented on S2GRAPH-9:
--------------------------------------
Github user hsleep commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/8#discussion_r49703039
--- Diff: s2core/src/main/scala/com/kakao/s2graph/core/PostProcess.scala ---
@@ -323,10 +323,17 @@ object PostProcess extends JSONParser {
to <- innerValToJsValue(edge.tgtVertex.id.innerId,
tgtColumn.columnType)
} yield {
val targetColumns = if (q.selectColumnsSet.isEmpty) reservedColumns
else (reservedColumns & q.selectColumnsSet) + "props"
+<<<<<<< HEAD:s2core/src/main/scala/com/kakao/s2graph/core/PostProcess.scala
--- End diff --
It has been merged incorrectly.
> Provide rest server using netty
> -------------------------------
>
> Key: S2GRAPH-9
> URL: https://issues.apache.org/jira/browse/S2GRAPH-9
> Project: S2Graph
> Issue Type: Sub-task
> Reporter: DOYUNG YOON
> Assignee: Daewon Jeong
> Priority: Minor
> Labels: project_structure, refactoring
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> I benchmarked with netty and it has much better performance with much less
> resources on query. since faster query means a lot, I think it would be
> better to add query rest server base on netty. also by implementing query
> server on different framework, we can find which codes are common and which
> are server framework specific.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
