[
https://issues.apache.org/jira/browse/S2GRAPH-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153866#comment-15153866
]
ASF GitHub Bot commented on S2GRAPH-37:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/20
[S2GRAPH-37] Extract LockExpireDuration as configuration.
+ Extract LockExpireDuration as configuration.
note that default value for lock.expire.time = 600 secs.
lock.expire.time > 2 * max.retry.number * max.back.off
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-37
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit fb0a45ae65d1a673c0899b9f2ee769fdcfe89faf
Author: DO YUNG YOON <[email protected]>
Date: 2016-02-19T07:42:18Z
S2GRAPH-37 Extract LockExpireDuration as configuration.
note that default value for lock.expire.time = 600 secs.
lock.expire.time > 2 * max.retry.number * max.back.off
----
> Extract LockExpireDuration as configuration
> -------------------------------------------
>
> Key: S2GRAPH-37
> URL: https://issues.apache.org/jira/browse/S2GRAPH-37
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: configuration
>
> LockExpireDuration on {{AsynchbaseStorage}} is parameter to decide how long
> lock on snapshot edge can be guaranteed. if this value has been elapsed after
> one request acquired lock on snapshot edge, then other request can break this
> lock and overwrite it.
> it is hard coded as Math.max(MaxRetryNum * MaxBackOff * 2, 10000) currently
> and I think it would be better to change it as configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
