[
https://issues.apache.org/jira/browse/S2GRAPH-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158327#comment-15158327
]
ASF GitHub Bot commented on S2GRAPH-37:
---------------------------------------
Github user elric-k commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/20#issuecomment-187547852
+1
> Extract LockExpireDuration as configuration
> -------------------------------------------
>
> Key: S2GRAPH-37
> URL: https://issues.apache.org/jira/browse/S2GRAPH-37
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: configuration
>
> LockExpireDuration on {{AsynchbaseStorage}} is parameter to decide how long
> lock on snapshot edge can be guaranteed. if this value has been elapsed after
> one request acquired lock on snapshot edge, then other request can break this
> lock and overwrite it.
> it is hard coded as Math.max(MaxRetryNum * MaxBackOff * 2, 10000) currently
> and I think it would be better to change it as configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
