[
https://issues.apache.org/jira/browse/S2GRAPH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305096#comment-15305096
]
ASF GitHub Bot commented on S2GRAPH-81:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/52
[S2GRAPH-81]: Separate Serializable's toKeyValues into 3, toRowKey,
toQualifier, toValue
+ split toKeyValues into toRowKey, toQualifier, toValue, so buildRequest
only use toRowKey, toQualifier.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-81
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 360daba9da38659cc1e1fb9b75ee667265b8700c
Author: DO YUNG YOON <[email protected]>
Date: 2016-03-28T13:10:42Z
[S2GRAPH-66]: Optimize toEdge, IndexEdgeDeserializable using mutable Map.
use immutable.Map.newBuilder to build merged props.
commit c3c3ecf12a51c930a52944ab4bc5143575c9349b
Author: DO YUNG YOON <[email protected]>
Date: 2016-05-28T01:18:37Z
[S2GRAPH-69]: Change IndexEdge's props data type.
commit 0d5ed4b6cb5c5c1528116a77be86d4fa319e1a27
Author: DO YUNG YOON <[email protected]>
Date: 2016-03-29T08:12:35Z
[S2GRAPH-81]: Separate Serializable's toKeyValues into 3, toRowKey,
toQualifier, toValue.
- split toKeyValues into toRowKey, toQualifier, toValue, so buildRequest
only use toRowKey, toQualifier.
----
> Separate Serializable's toKeyValues into 3, toRowKey, toQualifier, toValue
> --------------------------------------------------------------------------
>
> Key: S2GRAPH-81
> URL: https://issues.apache.org/jira/browse/S2GRAPH-81
> Project: S2Graph
> Issue Type: Sub-task
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Minor
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> {{StorageSerializable}} trait under core.storage package only have following
> interface.
> {noformat}
> trait StorageSerializable[E] {
> def toKeyValues: Seq[SKeyValue]
> }
> {noformat}
> This layer is responsible to build {{SKeyValue}} from {{Edge}}/{{Vertex}},
> which will be used in each storage implementation to actually store them.
> I am suggesting to separate this into 3 piece.
> # toRowKey
> # toQualifier
> # toValue
> The reason behind of this suggestion is for read path.
> When user query comes in, we need to build rpc into storage which require us
> to identify the row key.
> Most of time, we only need to identify row key, when getEdges from certain
> start vertex.
> Sometimes, we additionally need qualifier, when check if edge exist between
> vertex pair on specific Label.
> We are identifying row, qualifier by using {{IndexEdgeSerializer}}, which
> currently build bytes for row, qualifier, value altogether.
> I think by separating {{toKeyValues}}, read path can avoid unnecessary
> serialization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
