[
https://issues.apache.org/jira/browse/S2GRAPH-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451240#comment-15451240
]
ASF GitHub Bot commented on S2GRAPH-102:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/72
[S2GRAPH-102]: Add more configuration optoins in application.conf
+ add important s2graph options on conf/application.conf.
+ specify project version on build.sbt.
+ update HBase, Hadoop version to latest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-102
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit db21dd6af89b31629c3db735968c42b85efb4cf7
Author: DO YUNG YOON <[email protected]>
Date: 2016-08-31T01:26:02Z
add description on configurations.
commit 618e2d5a27d456994bb24ef5247ad52a84962bf5
Author: DO YUNG YOON <[email protected]>
Date: 2016-08-31T05:45:24Z
update HBase version and add comments for configurations for s2graph on
application.conf.
commit 95133f02d1fa0c6936ebd5680329be61ef34c915
Author: DO YUNG YOON <[email protected]>
Date: 2016-08-31T05:50:59Z
add project version on build.sbt.
----
> Add more configuration optoins in application.conf
> --------------------------------------------------
>
> Key: S2GRAPH-102
> URL: https://issues.apache.org/jira/browse/S2GRAPH-102
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently we only provide very minimum configuration options on
> application.conf, which can be found at
> target/apache-s2graph-$version-incubating-bin/conf/.
> {noformat}
> db.default.url="jdbc:h2:file:./var/metastore;MODE=MYSQL"
> db.default.user="sa"
> db.default.password="sa"
> {noformat}
> I think it would be better to provide configuration options with simple
> explanation on application.conf.
> We have various configurations such as connecting remote HBase cluster and
> Asynchbase client configurations, S2Graph's cache configuration etc.
> I am suggesting to list these reasonably important configurations with
> comment with informations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
