[
https://issues.apache.org/jira/browse/S2GRAPH-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452136#comment-15452136
]
ASF GitHub Bot commented on S2GRAPH-102:
----------------------------------------
Github user SteamShon commented on a diff in the pull request:
https://github.com/apache/incubator-s2graph/pull/72#discussion_r76979994
--- Diff: dev_support/docker-compose.yml ---
@@ -7,14 +7,14 @@
#
# http://www.apache.org/licenses/LICENSE-2.0
#
-# Unless required by applicable law or agreed to in writing, software
+# Unless required by applicable law or agreed to in writing, softwared
--- End diff --
@daewon I just pushed fix for this type.
> Add more configuration optoins in application.conf
> --------------------------------------------------
>
> Key: S2GRAPH-102
> URL: https://issues.apache.org/jira/browse/S2GRAPH-102
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently we only provide very minimum configuration options on
> application.conf, which can be found at
> target/apache-s2graph-$version-incubating-bin/conf/.
> {noformat}
> db.default.url="jdbc:h2:file:./var/metastore;MODE=MYSQL"
> db.default.user="sa"
> db.default.password="sa"
> {noformat}
> I think it would be better to provide configuration options with simple
> explanation on application.conf.
> We have various configurations such as connecting remote HBase cluster and
> Asynchbase client configurations, S2Graph's cache configuration etc.
> I am suggesting to list these reasonably important configurations with
> comment with informations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
