[
https://issues.apache.org/jira/browse/S2GRAPH-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467635#comment-15467635
]
ASF GitHub Bot commented on S2GRAPH-109:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/78
[S2GRAPH-109]: Merge duplicate test.sh into one same as `Your First Graph`
on README.md
+ deprecate `test.sh`.
+ `Your First Graph` on REAME.md is on `bin/example.sh`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 1b24751a0358dee43241a5a262081f47a9967def
Author: DO YUNG YOON <[email protected]>
Date: 2016-09-06T14:44:20Z
merge test.sh into bin/example.sh
commit 7c2f143fe1a7609a7008fa635615d577b26252c7
Author: DO YUNG YOON <[email protected]>
Date: 2016-09-06T15:07:55Z
update bin/example.sh.
----
> Merge duplicate test.sh into one same as `Your First Graph` on README.md
> ------------------------------------------------------------------------
>
> Key: S2GRAPH-109
> URL: https://issues.apache.org/jira/browse/S2GRAPH-109
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.1.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently two version of test.sh reside on root directory and `script/`.
> the one on root directory does not even works because it do not have proper
> setup for creating test service, label, etc.
> Also I think it would be better to provide `Your First Graph` as script so
> user who build from source can test if server works correctly.
> As far as I remember the intent of `test.sh` was same with `Your First Graph`
> so I am suggesting cleanup multiple `test.sh` into one same as `Your First
> Graph`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
