[ 
https://issues.apache.org/jira/browse/S2GRAPH-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485613#comment-15485613
 ] 

Jong Wook Kim commented on S2GRAPH-109:
---------------------------------------

It didn't pick up my suggestions at 
https://github.com/SteamShon/incubator-s2graph/pull/4/files  :(

They are not crucial but would be nice to have. Should I create a new issue?

> Merge duplicate test.sh into one same as `Your First Graph` on README.md
> ------------------------------------------------------------------------
>
>                 Key: S2GRAPH-109
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-109
>             Project: S2Graph
>          Issue Type: Sub-task
>    Affects Versions: 0.1.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>             Fix For: 0.1.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Currently two version of test.sh reside on root directory and `script/`. 
> the one on root directory does not even works because it do not have proper 
> setup for creating test service, label, etc.
> Also I think it would be better to provide `Your First Graph` as script so 
> user who build from source can test if server works correctly. 
> As far as I remember the intent of `test.sh` was same with `Your First Graph` 
> so I am suggesting cleanup multiple `test.sh` into one same as `Your First 
> Graph`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to