+1 (non-binding) Only from your docker image, sbt "test-only org.apache.s2graph.core.types.InnerValTest” fails, but it seems like a locale issue and should be ignored in favor of this release.
When you do: javap -v s2core/target/scala-2.11/test-classes/org/apache/s2graph/core/types/InnerValTest\$\$anonfun\$1.class | grep "=\ String" It will show the encoded String “가” and “나” incorrectly, and I presume that it’s somehow causing an ArrayIndexOutOfBoundsException during InnerValTest. It runs okay on my mac and (non-docker) mint 17.3. We may want to either specify how to set up the locale properly, or forbid non-ASCII characters in the source code, for example by using “\uAC00” instead of “가”. > On Oct 10, 2016, at 8:37 AM, DO YUNG YOON <[email protected]> wrote: > > +1 (non-binding) > > I tried RC6 on ubuntu 16.04, SBT 0.13.9, SCALA 2.11.7, OpenJDK 1.8.0_91. > > BTW, I got tire of taking too much time to download all dependencies, so > created docker image for above environment at docker hub. > Anyone can pull this image by `docker pull steamshon/incubator-s2graph`. > > Checked followings. > > 1. Checksums and PGP signatures are valid > 2. Release consists of source code only, no binaries > 3. DISCLAIMER is correct, filenames include "incubating", top level NOTICE > and LICENSE files. > 4. Check license header on files by following DEVELOPMENT.md. > 5. Test if I can run `bin/example.sh` after build. > 6. `sbt compile`, `sbt test:compile` to see any compile errors. > 7. `sbt "project loader" assembly`, `sbt "project s2counter_loader"` > assembly to see executable jar successfully built from source. > 8. `sbt test` to see if all test cases passed. > > Thanks. > > On Mon, Oct 10, 2016 at 2:30 PM DO YUNG YOON <[email protected]> wrote: > >> Hi all >> >> This is a call for a releasing Apache S2Graph 0.1.0-incubating, release >> candidate 6. >> This is the first release of S2Graph. >> >> The source tarball, including signatures, digests, etc. can be found at: >> >> https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.1.0-incubating-RC6/ >> >> The tag to be voted upon is v0.1.0-incubating-rc6: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.git;a=shortlog;h=refs/tags/v0.1.0-incubating-rc6 >> >> The release hash is 4325ff1303ce606909bc16b5cbee53c8a5b23653: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.git;a=commit;h=4325ff1303ce606909bc16b5cbee53c8a5b23653 >> >> >> Release artifacts are signed with the following key: >> https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS >> >> Once download source, please look into README.md to build from source. >> >> Following issues are resolved. >> >> - S2GRAPH-117: Cleaner logging library usage. >> - S2GRAPH-118: Fix compile error on test cases on loader project. >> - S2GRAPH-120: Netty version is conflict with play 2.5.9. >> >> >> The vote will be open for at least 72 hours. Unless objection I will try >> to close it Sunday September 25 if we have sufficient votes. >> >> Please download the release candidate and evaluate the necessary items >> including checking hashes, signatures, build from source, and test. >> please vote: >> >> [ ] +1 Release this package as 0.1.0 >> [ ] +0 no opinion >> [ ] -1 Do not release this package because... >> >> Thanks, >> DOYUNG YOON. >>
