[
https://issues.apache.org/jira/browse/S2GRAPH-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653084#comment-15653084
]
ASF GitHub Bot commented on S2GRAPH-127:
----------------------------------------
GitHub user daewon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/95
[S2GRAPH-127] Refactor ExceptionHander Object into Class.
Improvement
We are using one single global object ExceptionHandler to handle both of
following fail scenario.
- To publish all incoming requests(`WALLOG`) into kafka topic.
- To publish failed mutations when `Storage` failed to mutate into backend
storage.
WALLOG should be handled on REST server layer, not in s2core.
FAILLOG on storage backend should be handled in s2core.
Let's separate two case by changing ExceptionHandler from object to class
so each case can use separate class instance for each usage.
Basically, any failure on s2core should throw exception so client can
decide how to process exception, but this can be large issue so let's make it
separate issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daewon/incubator-s2graph S2GRAPH-127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 6b87825c541851bb402997a179b3beedc113c841
Author: daewon <[email protected]>
Date: 2016-04-21T02:48:28Z
[ISSUE-82] Refactor Exception Handler
----
> Refactor ExceptionHander Object into Class.
> -------------------------------------------
>
> Key: S2GRAPH-127
> URL: https://issues.apache.org/jira/browse/S2GRAPH-127
> Project: S2Graph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Daewon Jeong
> Priority: Minor
>
> Improvement
> We are using one single global object ExceptionHandler to handle both of
> following fail scenario.
> # To publish all incoming requests({{WALLOG}}) into kafka topic.
> # To publish failed mutations when {{Storage}} failed to mutate into backend
> storage.
> {{WALLOG}} should be handled on REST server layer, not in {{s2core}}.
> {{FAILLOG}} on storage backend should be handled in {{s2core}}.
> Let's separate two case by changing ExceptionHandler from object to class so
> each case can use separate class instance for each usage.
> Basically, any failure on s2core should throw exception so client can decide
> how to process exception, but this can be large issue so let's make it
> separate issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
