[
https://issues.apache.org/jira/browse/S2GRAPH-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653403#comment-15653403
]
ASF GitHub Bot commented on S2GRAPH-127:
----------------------------------------
Github user SteamShon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/95
looks good to me!
> Refactor ExceptionHander Object into Class.
> -------------------------------------------
>
> Key: S2GRAPH-127
> URL: https://issues.apache.org/jira/browse/S2GRAPH-127
> Project: S2Graph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Daewon Jeong
> Priority: Minor
>
> Improvement
> We are using one single global object ExceptionHandler to handle both of
> following fail scenario.
> # To publish all incoming requests({{WALLOG}}) into kafka topic.
> # To publish failed mutations when {{Storage}} failed to mutate into backend
> storage.
> {{WALLOG}} should be handled on REST server layer, not in {{s2core}}.
> {{FAILLOG}} on storage backend should be handled in {{s2core}}.
> Let's separate two case by changing ExceptionHandler from object to class so
> each case can use separate class instance for each usage.
> Basically, any failure on s2core should throw exception so client can decide
> how to process exception, but this can be large issue so let's make it
> separate issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
