[
https://issues.apache.org/jira/browse/S2GRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691913#comment-15691913
]
ASF GitHub Bot commented on S2GRAPH-129:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/99
[S2GRAPH-129]: Restrict direct access on Edge's properties from other
classes.
- add tp3 as dependencies.
- make propsWithTs as private.
Note that interface is not implemented on this PR. Few separate issues will
be followed up base on this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 292174ecf8da32604d61cb5f8388b8d9eeb54be3
Author: DO YUNG YOON <[email protected]>
Date: 2016-11-24T01:46:27Z
[S2GRAPH-129]: Restrict direct access on Edge's properties from other
classes.
- add tp3 as dependencies.
- make propsWithTs as private.
----
> Restrict direct access on Edge's properties from other classes.
> ---------------------------------------------------------------
>
> Key: S2GRAPH-129
> URL: https://issues.apache.org/jira/browse/S2GRAPH-129
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is about restrict accessibility of {{Edge.propsWithTs}} variable by
> changing it to be {{private}}, then provide methods to manipulate them
> instead of directly accessing them from other classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
