[
https://issues.apache.org/jira/browse/S2GRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704398#comment-15704398
]
ASF GitHub Bot commented on S2GRAPH-129:
----------------------------------------
Github user HyunsungJo commented on the issue:
https://github.com/apache/incubator-s2graph/pull/99
* All tests pass in my local environment.
* `CanInnerValLike` is this the best naming of this object? If so, LGTM.
> Restrict direct access on Edge's properties from other classes.
> ---------------------------------------------------------------
>
> Key: S2GRAPH-129
> URL: https://issues.apache.org/jira/browse/S2GRAPH-129
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is about restrict accessibility of {{Edge.propsWithTs}} variable by
> changing it to be {{private}}, then provide methods to manipulate them
> instead of directly accessing them from other classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
