[
https://issues.apache.org/jira/browse/S2GRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894473#comment-15894473
]
ASF GitHub Bot commented on S2GRAPH-136:
----------------------------------------
Github user echarles commented on the issue:
https://github.com/apache/incubator-s2graph/pull/112
A few feedbacks after testing this branch:
- The tinkerpop integration tests are configured with mysql (changed it to
h2) and an external hbase cluster: is this what we want
- S2GraphStructureIntegrateTest returns `he StructureIntegrateSuite will
not run for this Graph until it is publicly acknowledged with the @OptIn
annotation on the Graph instance itself`
- S2GraphStructureStandardTest has many methods: most of them are ignored
with "org.junit.AssumptionViolatedException: S2Graph does not support all of
the features required by this test so it will be ignored:" - Some are green :
Great1 - others are red (eg: shouldRemoveEdges with
java.lang.IllegalArgumentException at
org.apache.s2graph.core.S2Vertex.addEdge(S2Vertex.scala:198))
Happy to further work here to get more green methods - Where to start?
> Validate TinkerPop3 interface with gremlin-test suite.
> ------------------------------------------------------
>
> Key: S2GRAPH-136
> URL: https://issues.apache.org/jira/browse/S2GRAPH-136
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> S2GRAPH-131 add naive implementation of tinkerpop structure api.
> It would be great to validate if S2Graph's implementation through
> gremlin-test.
> reference:
> http://tinkerpop.apache.org/docs/3.2.3/dev/provider/#validating-with-gremlin-test
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
