[
https://issues.apache.org/jira/browse/S2GRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895693#comment-15895693
]
ASF GitHub Bot commented on S2GRAPH-136:
----------------------------------------
Github user SteamShon commented on the issue:
https://github.com/apache/incubator-s2graph/pull/112
@echarles
Thanks for feedbacks
- The tinkerpop integration tests are configured with mysql (changed it to
h2) and an external hbase cluster: is this what we want?
good point. I think it would be better for us to configure our tests can be
run without any setup(like external hbase cluster). I suggest to change this to
use h2 + embedded standalone hmaster as default for test to easy testing
environment setup. I have naive version for this change, and I will push this
commit under this PR.
- S2GraphStructureIntegrateTest returns he StructureIntegrateSuite will not
run for this Graph until it is publicly acknowledged with the @OptIn annotation
on the Graph instance itself
I think IntegrateTest is optional(based on
[here](http://tinkerpop.apache.org/docs/current/dev/provider/#validating-with-gremlin-test)).
I am still struggling to pass `StructureStandardSuite`(not many green yet) and
I think once I am done with`StructureStandardSuite` then start dig it.
I think best way to get started is running `StructureStandardSuite` and
find out failed cases and debug them and you can start work by comment out
@Graph.OptOuts(S2Graph.scala:532).
Many test cases in `StructureStandardSuite` expect their own
Edge/Vertex/Property schema with specific data, so figuring out schema then
place them under `S2GraphProvider.loadGraphData`, then comment out that OptOut,
then debug it...It may not right way, but since I have very limited knowledge
on gremlin-test, I was learning in this hard way. happy to learn better way.
> Validate TinkerPop3 interface with gremlin-test suite.
> ------------------------------------------------------
>
> Key: S2GRAPH-136
> URL: https://issues.apache.org/jira/browse/S2GRAPH-136
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> S2GRAPH-131 add naive implementation of tinkerpop structure api.
> It would be great to validate if S2Graph's implementation through
> gremlin-test.
> reference:
> http://tinkerpop.apache.org/docs/3.2.3/dev/provider/#validating-with-gremlin-test
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
