Hi,

apologize for the late vote.

-1 (binding)

So far I've successfully checked:
* signatures and digests
* source releases file layouts
* matched git tags and commit ids
* incubator suffix and disclaimer
* NOTICE and LICENSE files
* license headers
* clean build (Java 1.8.0_131, Scala, 2.11.8, SBT 0.13.12, Debian amd64)

I still got quite some warnings on the build, as happened for
0.1.0-incubating.

But why I vote negatively to the release it isn't any formal requirement,
but a functional error I think should be easy to fix:

$ sh bin/start-s2graph.sh
bin/start-s2graph.sh: 22:
/home/wikier/tmp/s2graph/apache-s2graph-0.2.0-incubating-src/bin/s2graph-env.sh:
Bad substitution

Already reported as S2GRAPH-159. I'll provide a patch to fix it.

BTW, the file https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.
2.0-incubating-RC2/CHANGES claims changes for "Release 0.1.0 - unreleased".

Best,


On Mon, Aug 7, 2017 at 10:10 AM, DO YUNG YOON <sho...@gmail.com> wrote:

> Hi all
>
> This is a call for a releasing Apache S2Graph 0.2.0-incubating, release
> candidate 2.
>
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/0.
> 2.0-incubating-RC2
>
> The tag to be voted upon is v0.2.0-incubating-rc2:
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> git;a=shortlog;h=refs/tags/v0.2.0-incubating-rc2
>
> The release hash is 917475b62d68ac952716df5d8ce6465656ec1f25:
> https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph.
> git;a=commit;h=917475b62d68ac952716df5d8ce6465656ec1f25
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS
>
> Once download source, please look into README.md to build from source.
>
> Notable changes from 0.1.0 is providing tinkerpop3 integration(S2GRAPH-72,
> S2GRAPH-151).
>
> The vote will be open for at least 72 hours. Unless objection I will try to
> close it Wednesday August 9 if we have sufficient votes.
>
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.
> please vote:
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...
>
> Thanks,
> DOYUNG YOON.
>

Reply via email to