Thanks for your review daewon. On Tue, Aug 15, 2017 at 3:01 AM daewon <[email protected]> wrote:
> +1 (non-binding) > > I tested below work well in the following environment. > - sbt test > - sbt package > - run w/ example.sh > > # TEST ENV > > ## O/S > ``` > NAME="Ubuntu" > VERSION="16.04.2 LTS (Xenial Xerus)" > ID=ubuntu > ID_LIKE=debian > PRETTY_NAME="Ubuntu 16.04.2 LTS" > VERSION_ID="16.04" > HOME_URL="http://www.ubuntu.com/"; > SUPPORT_URL="http://help.ubuntu.com/"; > BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"; > VERSION_CODENAME=xenial > UBUNTU_CODENAME=xenial > ``` > > ## java > ``` > openjdk version "1.8.0_131" > OpenJDK Runtime Environment (build > 1.8.0_131-8u131-b11-2ubuntu1.16.04.3-b11) > OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode) > ``` > > > On Mon, Aug 14, 2017 at 9:57 AM DO YUNG YOON <[email protected]> wrote: > > > Hi Sergio, Thank you for reviewing RC3. > > > > - S2GRAPH-159: Appreciate your patch. > > - S2GRAPH-160: I identified 3 reasons for this issues( > > > > > https://issues.apache.org/jira/browse/S2GRAPH-160?focusedCommentId=16123376&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16123376 > > ). > > I am going to create 3 separate issue targeting next release. > > - S2GRAPH-161: got your point. I will create task to add `(incubating)` > > suffix on version. > > > > > > Best Regards > > > > On Sun, Aug 13, 2017 at 1:05 PM Sergio Fernández <[email protected]> > > wrote: > > > > > Hi, > > > > > > +1 (binding) > > > > > > So far I've successfully checked: > > > > > > * signatures and digests > > > * source releases file layouts > > > * matched git tags and commit ids > > > * incubator suffix and disclaimer > > > * NOTICE and LICENSE files > > > * license headers > > > * clean build (Java 1.8.0_131, Scala, 2.11.8, SBT 0.13.12, Debian > amd64) > > > > > > With respect to my vote to RC2: > > > > > > * S2GRAPH-159 has been fixed. > > > * S2GRAPH-160 has been minimized, not fixed, but looks much better. > > > * S2GRAPH-161 is not fully right, because new CHANGES file shows a > > version > > > without the incubating suffix. As the file is not part of the release > > > tarball it should be fine, but would be nice to keep that very clear. > > > > > > Thanks for the work on this new release! > > > > > > Cheers, > > > > > > > > > > > > On Sat, Aug 12, 2017 at 4:38 PM, DO YUNG YOON <[email protected]> > wrote: > > > > > > > +1 (non-binding) > > > > > > > > I tried RC3 on ubuntu 16.04, SBT 0.13.9, SCALA 2.11.7, OpenJDK > > 1.8.0_91. > > > > > > > > Checked followings. > > > > > > > > 1. Checksums and PGP signatures are valid > > > > 2. Release consists of source code only, no binaries > > > > 3. DISCLAIMER is correct, filenames include "incubating", top level > > > NOTICE > > > > and LICENSE files. > > > > 4. Check license header on files by following DEVELOPMENT.md. > > > > 5. Test if I can run `bin/example.sh` after build using `sbt > package`. > > > > 6. `sbt compile`, `sbt test:compile` to see any compile errors. > > > > 7. `sbt "project loader" assembly`, `sbt "project s2counter_loader"` > > > > assembly to see executable jar successfully built from source. > > > > 8. `sbt test` to see if all test cases passed. > > > > > > > > Thanks. > > > > > > > > On Sat, Aug 12, 2017 at 7:31 AM DO YUNG YOON <[email protected]> > wrote: > > > > > > > > > Hi all > > > > > > > > > > This is a call for a releasing Apache S2Graph 0.2.0-incubating, > > release > > > > > candidate 3. > > > > > > > > > > The source tarball, including signatures, digests, etc. can be > found > > > at: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/s2graph/0. > > > > 2.0-incubating-RC3 > > > > > > > > > > The tag to be voted upon is v0.2.0-incubating-rc3: > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph. > > > > git;a=shortlog;h=refs/tags/v0.2.0-incubating-rc3 > > > > > > > > > > The release hash is b66a56e39c250c8626286c4f4612c1f4b78adcf1: > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-s2graph. > > > > git;a=commit;h=b66a56e39c250c8626286c4f4612c1f4b78adcf1 > > > > > > > > > > Release artifacts are signed with the following key: > > > > > https://dist.apache.org/repos/dist/dev/incubator/s2graph/KEYS > > > > > > > > > > Once download source, please look into README.md to build from > > source. > > > > > > > > > > Notable changes from 0.1.0 is providing tinkerpop3 > > > > integration(S2GRAPH-72, > > > > > S2GRAPH-151). > > > > > > > > > > Changes from rc2 is following. > > > > > > > > > > - S2GRAPH-159: Wrong syntax at a bash script under Linux > > > > > - S2GRAPH-161: Update CHANGES file for 0.2.0 release > > > > > - S2GRAPH-160: Remove warning while package > > > > > > > > > > The vote will be open for at least 72 hours. Unless objection I > will > > > try > > > > > to close it Tuesday August 15 if we have sufficient votes. > > > > > > > > > > Please download the release candidate and evaluate the necessary > > items > > > > > including checking hashes, signatures, build from source, and test. > > > > > please vote: > > > > > > > > > > [ ] +1 Release this package as 0.2.0 > > > > > [ ] +0 no opinion > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > Thanks, > > > > > DOYUNG YOON. > > > > > > > > > > > > > > >
