[ https://issues.apache.org/jira/browse/S2GRAPH-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513425#comment-16513425 ]
ASF GitHub Bot commented on S2GRAPH-223: ---------------------------------------- GitHub user SteamShon opened a pull request: https://github.com/apache/incubator-s2graph/pull/175 [S2GRAPH-223]: Support WhereParser on Vertex. - Refactor WhereParser to accept GraphElement. - Refactor S2Graph.getVertices to accept VertexQueryParam. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-223 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-s2graph/pull/175.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #175 ---- commit 3b692fbead9accd6f9d0d9764800e15e945c90bb Author: DO YUNG YOON <steamshon@...> Date: 2018-06-15T05:59:13Z Refactor WhereParser to accept GraphElement, not Edge only. commit f47622fdeaee9fef9d46bf83c6191204dad00043 Author: DO YUNG YOON <steamshon@...> Date: 2018-06-15T06:35:16Z - Refactor WhereParser to accept GraphElement. - Refactor S2Graph.getVertices to accept VertexQueryParam. ---- > Support WhereParser on Vertex. > ------------------------------ > > Key: S2GRAPH-223 > URL: https://issues.apache.org/jira/browse/S2GRAPH-223 > Project: S2Graph > Issue Type: New Feature > Components: s2core > Reporter: DOYUNG YOON > Assignee: DOYUNG YOON > Priority: Major > > Currently, WhereParser is only available for Edge so it is not possible to > filter vertex with predicates. > One example query would look like followings. > {noformat} > query { > s2graph { > User(id: 1, filter: "name contains 'steamshon'") { > id > } > } > } > {noformat} > I suggest to add vertex support in WhereParser, so GraphQL query can also > benefit from WhereParser. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)