DOYUNG YOON commented on S2GRAPH-223:


Quick question on s2graphql code.

In above PR, I made necessary changes in s2core, especially followings.\

 # Refactored WhereParser to be able to filter GraphElement(Vertex and Edge).
 # Changed S2Graph.getVertices to accept VertexQueryParam instead of 

It seems like adding 'filter' on GraphQL query depends on

org.apache.s2graph.graphql.types.FieldResolver, but I am not sure how to add 
'filter' field on Vertex in s2graphql. 

Can you advice what needs to be changed to support above feature?



> Support WhereParser on Vertex.
> ------------------------------
>                 Key: S2GRAPH-223
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-223
>             Project: S2Graph
>          Issue Type: New Feature
>          Components: s2core
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Major
> Currently, WhereParser is only available for Edge so it is not possible to 
> filter vertex with predicates.
> One example query would look like followings.
> {noformat}
> query {
>   s2graph {
>     User(id: 1, filter: "name contains 'steamshon'") {
>       id
>     }
>   }
> }
> {noformat}
> I suggest to add vertex support in WhereParser, so GraphQL query can also 
> benefit from WhereParser.

This message was sent by Atlassian JIRA

Reply via email to