Thanks, I modified the wiki and merged the update. Seems that by merging we also simplify the closing of the PRs, which is a plus.
Regarding the guidelines, are you suggesting to adopt the naming scheme with modules or the breakdown in doc/code PRs? -- Gianmarco On 28 June 2015 at 20:59, Gyula Fóra <[email protected]> wrote: > Hey, > > I created a doc with my changes to the "Merge a pull request" part of the > guide (since I dont have edit rights to the wiki): > > https://docs.google.com/document/d/1PniTMEffzmXpb4iEgr36YCze8a1jhR9I18nVg6FZuz4/edit?usp=sharing > > Feel free to change anything the way you like it :) > > I also opened a small PR for a change to the CONTRIBUTING.md file. > > Also I suggest you to adapt a more informative guideline for PRs JIRAs and > commit messages such as in: > > https://cwiki.apache.org/confluence/display/FLINK/Apache+Flink+development+guidelines > > Cheers, > Gyula > > Gianmarco De Francisci Morales <[email protected]> ezt írta (időpont: 2015. > jún. 28., V, 17:20): > > > Yes, but as Gyula pointed out it assumes only a single author per PR. > > > > If we want to allow collaboration on a single PR then it's better to > avoid > > squashing the commits. > > > > > > > > gdfm@iPhone > > > > On Sat, Jun 27, 2015 at 7:29 PM, Ted Dunning <[email protected]> > > wrote: > > > > > On Sat, Jun 27, 2015 at 6:56 AM, Gianmarco De Francisci Morales < > > > [email protected]> wrote: > > >> I disagree that the traceability is a problem. There is a 1:1 mapping > > >> between a Jira and a PR and the mapping is kept in the commit log > > history. > > >> SVN based project have been working like this for a while. > > >> > > > Can I look in the commit log to find all contributions by a particular > > > person? >
