----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review144296 -----------------------------------------------------------
bin/generate-javadocs.sh (line 21) <https://reviews.apache.org/r/50154/#comment212142> We need to add this path to .gitignore. We should add this path to build.gradle excludes so that build will stop complaining about missing license headers on geenrated files. docs/learn/tutorials/versioned/samza-rest-getting-started.md (line 22) <https://reviews.apache.org/r/50154/#comment210303> nit: "executed a couple of basic curl ..." docs/learn/tutorials/versioned/samza-rest-getting-started.md (line 73) <https://reviews.apache.org/r/50154/#comment212172> Should change run-samza-rest-service.sh to be executable (chmod 755) docs/learn/tutorials/versioned/samza-rest-getting-started.md (line 88) <https://reviews.apache.org/r/50154/#comment212177> I am running in to an issue of not finding config files in the path specified. I don't get any response on curl. From the log file: 2016-08-15 17:36:23.417 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/lib/config 2016-08-15 17:36:23.417 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/bin/config 2016-08-15 17:36:23.417 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/tmp/config 2016-08-15 17:36:23.418 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/config/config 2016-08-15 17:36:44.029 [qtp1276504061-19] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/lib/config 2016-08-15 17:36:44.029 [qtp1276504061-19] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/bin/config 2016-08-15 17:36:44.029 [qtp1276504061-19] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/tmp/config 2016-08-15 17:36:44.030 [qtp1276504061-19] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/config/config 2016-08-15 17:37:12.480 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/lib/config 2016-08-15 17:37:12.481 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/bin/config 2016-08-15 17:37:12.481 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/tmp/config 2016-08-15 17:37:12.482 [qtp1276504061-18] SimpleInstallationFinder [WARN] Config path not found: /home/nramesh/Projects/samza-hello-samza/deploy/samza/config/config Looks like it is appening "config" to any path it tries to access. I have to look into your implementation code for why this is happening. Can you please check? - Navina Ramesh On July 29, 2016, 6:58 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50154/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 6:58 p.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-976 > https://issues.apache.org/jira/browse/SAMZA-976 > > > Repository: samza > > > Description > ------- > > SAMZA-976 Samza REST Documentation > > > Diffs > ----- > > bin/generate-javadocs.sh da9f32da8f2a1f89ff28178ee703c4a065189da8 > docs/img/versioned/learn/documentation/rest/JobsResource.png PRE-CREATION > docs/learn/documentation/versioned/index.html > 1e79bd6f39ee67b5a2b74222d647342990bbbe23 > docs/learn/documentation/versioned/rest/monitors.md PRE-CREATION > docs/learn/documentation/versioned/rest/overview.md PRE-CREATION > docs/learn/documentation/versioned/rest/resource-directory.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources/jobs.md PRE-CREATION > docs/learn/tutorials/versioned/index.md > b4d687a63638aca4f876af88556de9973acfd718 > docs/learn/tutorials/versioned/samza-rest-getting-started.md PRE-CREATION > > Diff: https://reviews.apache.org/r/50154/diff/ > > > Testing > ------- > > Verified by building the local site documentation and browsing. I wasn't able > to verify the javadoc. If anyone knows why java doc would not be generated > for new classes, I'd be interested to know. > > > Thanks, > > Jake Maes > >
