> On Aug. 16, 2016, 12:50 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 73 > > <https://reviews.apache.org/r/50154/diff/6/?file=1458034#file1458034line73> > > > > Should change run-samza-rest-service.sh to be executable (chmod 755) > > Jake Maes wrote: > I think it is. I just applied the patch from JIRA to a fresh copy of > samza on both my mac and linux machines an had no problems running through > the tutorial. > > Also: > ``` > samza-rest[master] > ls -la bin/run-samza-rest-service.sh > -rwxr-xr-x 1 1.0K Aug 16 12:43 bin/run-samza-rest-service.sh* > ``` > and > ``` > samza-rest[master] > ls > ../../../../src/main/bash/run-samza-rest-service.sh > -rwxr-xr-x 1 1.0K Aug 16 12:43 > ../../../../src/main/bash/run-samza-rest-service.sh* > ``` > > Navina Ramesh wrote: > Weird.. even with your new patch it still complained about permissions. > Never mind. I will verify it and fix it, if required before pushing it. > Thanks!
Hmm, maybe its a difference between ```git apply``` and ```patch``` commands. Thanks for making sure it works. And remember to also include the PNG file attached to the JIRA. The path is specified in the JIRA comments. - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50154/#review144296 ----------------------------------------------------------- On Aug. 17, 2016, 1:58 a.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50154/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 1:58 a.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-976 > https://issues.apache.org/jira/browse/SAMZA-976 > > > Repository: samza > > > Description > ------- > > SAMZA-976 Samza REST Documentation > > > Diffs > ----- > > .gitignore 3e974168cc4f982151758b6727c69f17b9013f8c > bin/generate-javadocs.sh da9f32da8f2a1f89ff28178ee703c4a065189da8 > docs/learn/documentation/versioned/index.html > 84e15a25bc8f1bb2996150bde24b81ff05dae224 > docs/learn/documentation/versioned/rest/monitors.md PRE-CREATION > docs/learn/documentation/versioned/rest/overview.md PRE-CREATION > docs/learn/documentation/versioned/rest/resource-directory.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources.md PRE-CREATION > docs/learn/documentation/versioned/rest/resources/jobs.md PRE-CREATION > docs/learn/tutorials/versioned/index.md > b4d687a63638aca4f876af88556de9973acfd718 > docs/learn/tutorials/versioned/samza-rest-getting-started.md PRE-CREATION > > Diff: https://reviews.apache.org/r/50154/diff/ > > > Testing > ------- > > Verified by building the local site documentation and browsing. I wasn't able > to verify the javadoc. If anyone knows why java doc would not be generated > for new classes, I'd be interested to know. > > > Thanks, > > Jake Maes > >
