sborya commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r264387433
########## File path: samza-azure/src/main/java/org/apache/samza/coordinator/AzureCoordinationUtils.java ########## @@ -52,6 +52,16 @@ public DistributedLockWithState getLockWithState(String lockId) { return new AzureLock(blob); } + @Override + public DistributedReadWriteLock getReadWriteLock(String lockId) throws UnsupportedOperationException { Review comment: you need to throw the exception here (instead of return null) and you may remove 'throws UOE' from the method signature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services