sborya commented on a change in pull request #938: SAMZA-1531: Support run.id
in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r264414547
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -59,13 +67,23 @@
public class LocalApplicationRunner implements ApplicationRunner {
private static final Logger LOG =
LoggerFactory.getLogger(LocalApplicationRunner.class);
+ private static final String RUNID_PATH = "runId";
+ private static final String APPLICATION_RUNNER_PATH_SUFFIX =
"/ApplicationRunnerData";
+ private static final String RUNID_LOCK_ID = "runId";
+ private static final int LOCK_TIMEOUT = 10;
Review comment:
I prefer LOCK_TIMEOUT_MS here and use TimeUnit.MINUTES directly (no need for
constant there)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
