cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade
to Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267871144
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala
##########
@@ -301,12 +260,6 @@ class TestKafkaSystemAdmin {
val spec = StreamSpec.createCoordinatorStreamSpec(topic, "kafka")
systemAdmin.createStream(spec)
validateTopic(topic, 1)
- val topicMetadataMap = TopicMetadataCache.getTopicMetadata(Set(topic),
"kafka", metadataStore.getTopicInfo)
- assertTrue(topicMetadataMap.contains(topic))
- val topicMetadata = topicMetadataMap(topic)
- val partitionMetadata = topicMetadata.partitionsMetadata.head
- assertEquals(0, partitionMetadata.partitionId)
- assertEquals(3, partitionMetadata.replicas.size)
Review comment:
The end-to-end check seems unnecessary anyways for a unit test.
However, since you are removing that check, it might be good to have a test
which uses Mockito to verify that the correct configurations are passed to the
admin client when creating topics. If I recall correctly, in the past, we may
have had some issues which involved replication factors (not sure if they were
this exact flow though).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
