cameronlee314 commented on a change in pull request #951: SAMZA-2127: Upgrade
to Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r267881671
##########
File path:
samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java
##########
@@ -295,4 +227,20 @@ public Config getConfig() {
return this.config;
}
}
+
+ @Override
+ protected KafkaProducer createProducer() {
Review comment:
It seems a bit odd that this test harness needs slightly different
serialization/deserialization for createProducer/createConsumer compared to
`IntegrationTestHarness`. If it is difficult to make them consistent, could you
please put a comment about why you have these overrides?
You could also consider having helpers in `IntegrationTestHarness` to build
the configs, just in case someone needs to add something in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
