+1 (binding). lgtm. Thanks! -Yi
On Mon, Dec 16, 2019 at 8:08 AM Daniel Nishimura <dnishim...@gmail.com> wrote: > +1. Thank Prateek for standardizing the PR process better. > > On Sun, Dec 15, 2019 at 10:55 PM Bharath Kumara Subramanian < > codin.mart...@gmail.com> wrote: > > > +1. Template looks good to me. > > It will be really helpful to sift through, categorize and prepare release > > notes from notable PRs during releases. > > > > Thanks, > > Bharath > > > > > > On Fri, Dec 13, 2019 at 11:24 PM Jagadish Venkatraman < > > jagadish1...@gmail.com> wrote: > > > > > +1, thanks for the write-up Prateek. > > > > > > Let's also update the contributor's guidelines at: > > > https://samza.apache.org/contribute/contributors-corner.html > > > > > > > > > On Friday, December 13, 2019, Prateek Maheshwari <prateek...@gmail.com > > > > > wrote: > > > > > > > Hi folks, > > > > > > > > In order to make Samza PR descriptions and commit messages more > > > consistent, > > > > informative and discoverable, we propose the following requirements > for > > > new > > > > PRs submitted to the Samza project > > > > > > > > https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+ > > > > PR+Title+And+Description+Guidelines > > > > > > > > Contributors should copy-paste and update the description template > when > > > > submitting PRs. > > > > Committers should ensure that the guidelines are followed before > > merging > > > > changes. > > > > > > > > Please take a look and let us know if you have any concerns or > > > suggestions. > > > > > > > > Thanks, > > > > Prateek > > > > > > > > > > > > > -- > > > Jagadish > > > > > >
