> On May 20, 2014, 5:12 p.m., Chris Riccomini wrote: > >
This looks really good. Most of my feedback is fairly minor. The one major issue I think we should correct is the handling of the offset in IncomingMessageEnvelope. Currently you're using the current offset when creating the envelope, but I think we need to use the offset that represents the beginning of the message, not its end. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21581/#review43489 ----------------------------------------------------------- On May 16, 2014, 9:15 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21581/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 9:15 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > 1. moved from old request SAMZA-138 > 2. new patch based on Samza core repository > 3. converted to Scala > 4. added javadoc for explaining > 5. FileReaderSystemAdmin implements SystemAdmin and provides metadata for a > file, including oldest offset, newest offset and upcming offset. > 6. FileReaderConsumer implements BlockingEnvelopeMap. It creates one thread > for each file-read operation. After reading existing messages, the thread > keeps checking the new messages coming to the file until the job is stopped. > 7. FileReaderFactory is implementing SystemFactory. > 8. related unit tests > > > Diffs > ----- > > > samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala > PRE-CREATION > > samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala > PRE-CREATION > > samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemFactory.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemAdmin.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemConsumer.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemFactory.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/21581/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
