----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21581/ -----------------------------------------------------------
(Updated May 22, 2014, 1:56 a.m.) Review request for samza. Changes ------- Hi Chris, thank you for reviewing! I updated the code according to your comments. Some of them are 1) use the beginning of the line for the offset that is put into IncomingMessageEnvelope 2) changed the implementation of getOffsetAfter method. Now it looks for the next newline, not simply +1 3) move queue size and polling sleep time into default parameters of FileReaderSystemConsumer. Also modified the Factory class to accept config. 4) all other changes you mentioned. Thank you. Repository: samza Description ------- 1. moved from old request SAMZA-138 2. new patch based on Samza core repository 3. converted to Scala 4. added javadoc for explaining 5. FileReaderSystemAdmin implements SystemAdmin and provides metadata for a file, including oldest offset, newest offset and upcming offset. 6. FileReaderConsumer implements BlockingEnvelopeMap. It creates one thread for each file-read operation. After reading existing messages, the thread keeps checking the new messages coming to the file until the job is stopped. 7. FileReaderFactory is implementing SystemFactory. 8. related unit tests Diffs (updated) ----- samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala PRE-CREATION samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala PRE-CREATION samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemFactory.scala PRE-CREATION samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemAdmin.scala PRE-CREATION samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemConsumer.scala PRE-CREATION samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemFactory.scala PRE-CREATION Diff: https://reviews.apache.org/r/21581/diff/ Testing ------- Thanks, Yan Fang
