----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26059/#review54728 -----------------------------------------------------------
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment95015> Is this 'setCacheSize' different from the one called above ? options.setCacheSize(cacheSize / containerContext.taskNames.size) ? - Chinmay Soman On Sept. 25, 2014, 11:17 p.m., Naveen Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26059/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-236 > https://issues.apache.org/jira/browse/SAMZA-236 > > > Repository: samza > > > Description > ------- > > Adding RocksDB Key-value support > > > Diffs > ----- > > build.gradle 357bb0e312c3812b55303847163f696f7c52ad78 > > samza-kv-leveldb/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > d6d437ab7a8b18002dbeb54d85c6c2b5eb43784c > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala > PRE-CREATION > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > PRE-CREATION > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/TestRocksDbApi.scala > PRE-CREATION > > samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala > 7d0b8db0c3bf1e70fd6af03abb594c7000e6666b > settings.gradle 325cac27389093d87eb9e36d475e234ed52510ec > > Diff: https://reviews.apache.org/r/26059/diff/ > > > Testing > ------- > > Unit testing > > > Thanks, > > Naveen Somasundaram > >
