----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26059/#review55169 -----------------------------------------------------------
build.gradle <https://reviews.apache.org/r/26059/#comment95552> Discussed with Chinmay, I just copied it from LevelDB (where a test depends on it), but for RocksDB it's not necessary. build.gradle <https://reviews.apache.org/r/26059/#comment95554> I rebased against the master, removing dependency. Thanks, will give rbt a shot :) samza-kv-leveldb/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala <https://reviews.apache.org/r/26059/#comment95555> done! samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala <https://reviews.apache.org/r/26059/#comment97234> done! samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala <https://reviews.apache.org/r/26059/#comment97232> done! samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala <https://reviews.apache.org/r/26059/#comment97235> done! samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala <https://reviews.apache.org/r/26059/#comment97236> deleted this samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97237> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97238> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97239> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97240> I am exposing all of them for now, we can play with it later. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97262> Some of the configuration options have changed, I have changed them and also exposed configurations to change them. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97243> I have removed it. I was overriding it for testing. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97263> addressed samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97264> addressed samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97266> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97267> pointed to the bug :) samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97268> removed all comments samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97269> By default, the iterator points to null, seekToFirst points it to the right position. https://github.com/facebook/rocksdb/blob/c8e70e6bf862f589d2b38a95bac3f03206d44ba8/table/iterator.cc samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97273> I did some research and it's actually supported, but I don't see it exposed in Java :( I'll open a ticket for them. It's exposed in perl: http://search.cpan.org/~jiro/RocksDB-0.02/lib/RocksDB.pm samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97274> fixed samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97275> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97276> done samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala <https://reviews.apache.org/r/26059/#comment97298> Moved it to samza-core and extended to use it both on leveldb and rocksdb as dicusssed offline. samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/TestRocksDbApi.scala <https://reviews.apache.org/r/26059/#comment97297> I am going to get rid of this file, I just created this purely for testing the API. - Naveen Somasundaram On Oct. 16, 2014, 2:16 a.m., Naveen Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26059/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 2:16 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-236 > https://issues.apache.org/jira/browse/SAMZA-236 > > > Repository: samza > > > Description > ------- > > Adding RocksDB Key-value support > > > Diffs > ----- > > build.gradle 1b37dbb4b9c74bbf8556a82da4e39ee7f3490dd6 > gradle/dependency-versions.gradle fe2e446e0f9d0d89ec3f522a43d0acf921ae3801 > > samza-core/src/main/scala/org/apache/samza/util/LexicographicComparator.scala > PRE-CREATION > > samza-kv-leveldb/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala > 853de121358c24c29111670c57423603acd09a7c > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala > PRE-CREATION > > samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala > PRE-CREATION > > samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala > 8fd33f1d4c25737bf6fb52627935f9157983b4e6 > > samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > eefe11494f4bd0a1710627614a9ab6bc2ee844d8 > settings.gradle 325cac27389093d87eb9e36d475e234ed52510ec > > Diff: https://reviews.apache.org/r/26059/diff/ > > > Testing > ------- > > Unit testing > > > Thanks, > > Naveen Somasundaram > >
