Hi Kohei, On Wednesday, 2008-03-19 09:27:11 -0400, Kohei Yoshida wrote:
> Well, if it's not used in the UI, I guess we can leave the English
> symbols alone. I'll change the implementation.
Btw, please don't use direct bit operations on the grammar value:
if ((eGrammar & FormulaLanguage::NATIVE))
Always use the inline methods provided by ScGrammar instead, in this
case that would be
if ((ScGrammar::extractFormulaLanguage( eGrammar) ==
FormulaLanguage::NATIVE))
If we ever had to rearrange internal representation of the grammars that
would still work then without having to adapt such places or even worse
miss them. Thanks.
In compiler.cxx +1396 there's
aRef.Ref1.CalcAbsIfRel( rComp.GetPos() );
duplicated from line 1402, intentional? I think that had to be moved
instead.
> > Umm.. the address convention is already switched based on the grammar.
> > Or what is missing?
>
> Ah no. I didn't see it the first time. Now I do. This means I won't
> have to do any extra work, which is good. ;-)
Sure :-)
Eike
--
OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer.
SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS
Please don't send personal mail to the [EMAIL PROTECTED] account, which I use
for
mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED]
Thanks.
pgpE3gzIgKbNL.pgp
Description: PGP signature
