On Thu, 2008-03-20 at 13:26 +0100, Eike Rathke wrote: > Hi Kohei, > > On Wednesday, 2008-03-19 09:27:11 -0400, Kohei Yoshida wrote: > > > Well, if it's not used in the UI, I guess we can leave the English > > symbols alone. I'll change the implementation. > > Btw, please don't use direct bit operations on the grammar value: > > if ((eGrammar & FormulaLanguage::NATIVE)) > > Always use the inline methods provided by ScGrammar instead, in this > case that would be > > if ((ScGrammar::extractFormulaLanguage( eGrammar) == > FormulaLanguage::NATIVE))
No problem. Just made that change. > In compiler.cxx +1396 there's > > aRef.Ref1.CalcAbsIfRel( rComp.GetPos() ); > > duplicated from line 1402, intentional? I think that had to be moved > instead. Good eye. :-) I believe that call was supposed to be moved, not duplicated. I just removed the original call on line 1402. Thanks! Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. <[EMAIL PROTECTED]> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
