Daniel Rentz schrieb:
Jonathan Pryor schrieb:
On Fri, 2008-11-21 at 11:57 +0100, Daniel Rentz wrote:
with some surprise I have seen hundrets of check ins in the CWS
ooxml02 with the goal to implement OOXML export filters. For Calc
this seems to be done by extending the binary BIFF export filter. As
it looks this makes it necessary to export headers from and linking
against oox thus making the sc module dependent from oox. I wonder if
this design decision with such an impact has been discussed somewhere
before.
It wasn't actually discussed at all, and no thought went into it; it was
the easiest thing to do.
The oox module has been started to be independent from most modules to
make the entire office a bit more modular.
Understood.
So, what's the solution to this? In particular, a reasonably fast
solution as I'd like to get this merged for OpenOffice.org 3.1. :-)
I see the following solutions:
1. Leave the dependency, merge ooxml02 for 3.1, and work to remove it
for 3.2+.
2. Split out oox's XmlFilterBase & dependent types into a helper library
(or perhaps use comphelper?), and depend on this helper library from
both sc & oox.
3. Implement BIFF/OOXML export within oox.
(1) is obviously the easiest, requiring no immediate work, and the "work
to remove it for 3.2+" could be (2) or (3).
I'm not sure how feasible (2) actually is -- it looks doable, but I'm
not sure what hidden issues will show up, nor what library it would be
appropriate to move FilterBase, XmlFilterBase, ZipStorage, etc. into.
Cursory discussions suggest that comphelper may be a good destination,
as sc already indirectly depends upon comphelper, so it's not really
adding anything that wasn't there before.
I don't like (2). I think best thing is to do (1), and think about (3)
for 3.x as you suggested.
... reading this ... should have written a reason for disliking (2) :-)
As you said, separating the base code from filter code may raise hidden
issues and would make everything more complicated (working/building in 2
or more modules etc)... And I think this filter stuff is a little bit
too special for comphelper.
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
