Regina Henschel schrieb:
Hi Daniel,

That works. When exporting to xls, I get the correct function structure, if there are one, two or three parameters in OOo. If there are four parameters in OOo, I get a =#NV entry in German Excel 2007. I think, the error message is correct, because the user has to know, that there has been something, which is unknown to Excel.

It is a concession that the missing parameters are added, although the user who will export to Excel-format should know, that Excel expects three parameters. Shouldn't we do the same for saving in old OOo formats, especially, when OOo3.0 is set in general to use ODF1.0-format? If you agree, that in cases saving to old OOo-formats the missing second and third parameters should be added, where is the place to do it?

I don't know the code that exports to ODF, Eike should know more.


To delete the 4th parameter, you can change the function info of this function. Go to xlformula.cxx and look for ocLogNormDist, change the
...

I have done first the changes in formulabase.cxx. That gives no error, but I see no effect, so I cannot say if it really works. Then I changed xlformula.cxx. That works, now the entry in the xls-file has three parameters in all cases.

Yes, formulabase.cxx is currently used for import from XLSX/XLSB format only, not export, so that does not have any effect on the XLS export filter. It is just a good idea to change both files equally to be prepared for the future where formulabase.cxx might be used for import/export of the XLS format too. The oox code module already contains a nearly complete XLS import filter that is intended to replace the old filter code from the sc module sometimes.


I have rethought the problem. It seems no good idea to strip the fourth parameter. If it is stripped, there are no errors in Excel, but the cells might have different values than OOo, because in OOo you calculate the density function and in Excel the cumulative function is calculated. The user cannot notice, that the values are wrong, because there are no warnings. That is not good and we should not do it. There is no way to determine whether the forth parameter is true or false, because it might be no constant but a reference.

The same problem is, when saving to old OOo-formats. Using four parameters should give an error, when opening in old versions.

Of course this is something that has to be decided before. There are functions where stripping a parameter unknown to Excel is desired, otherwise this might be not a good idea for other functions. Currently, the only way to "warn" the user is to write #NA instead of the (wrong) function argument list, so this is a valid option.

Again, Eike, what do you think?


Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@sc.openoffice.org
For additional commands, e-mail: dev-h...@sc.openoffice.org

Reply via email to