lewismc commented on a change in pull request #6: SDAP-35 (completed the 
configuration change)
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172925960
 
 

 ##########
 File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
 ##########
 @@ -138,48 +135,38 @@ private InputStream locateConfig() {
       LOG.info("Loaded config file from " + configFile.getAbsolutePath());
       return configStream;
     } catch (IOException e) {
-      LOG.info("File specified by environment variable " + 
MudrodConstants.MUDROD_CONFIG + "=\'" + configLocation + "\' could not be 
loaded. " + e.getMessage());
+      LOG.info("File specified by environment variable " + 
MudrodConstants.MUDROD_CONFIG + "=\'" + configLocation + "\' could not be 
loaded. Default configuration will be used." + e.getMessage());
 
 Review comment:
   For any instance of logging which involves parameter substitution, you 
should use [parameterized 
logging](https://www.slf4j.org/faq.html#logging_performance) e.g.
   ```
   LOG.error("File specified by environment variable {} = '{}' could not be 
loaded. Default configuration will be used.", MudrodConstants.MUDROD_CONFIG, 
configLocation, e.getMessage());
   ```
   Note it should also be a LOG.error not LOG.info

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to