lewismc commented on a change in pull request #6: SDAP-35 (completed the 
configuration change)
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172927334
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/metadata/structure/MetadataExtractor.java
 ##########
 @@ -67,15 +67,15 @@ public MetadataExtractor() {
    * @param type  metadata type name
    * @return metadata list
    */
-  protected List<PODAACMetadata> loadMetadataFromES(ESDriver es, String index, 
String type) {
+  protected List<Metadata> loadMetadataFromES(ESDriver es, String index, 
String type) {
 
-    List<PODAACMetadata> metadatas = new ArrayList<PODAACMetadata>();
+    List<Metadata> metadatas = new ArrayList<Metadata>();
 
 Review comment:
   Just use the diamond type operator no need to dual define the type. Should be
   ```
   List<Metadata> metadatas = new ArrayList<>();
   ```
   I would also suggest that you change the variable name to something more 
description such as ```metadataList```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to