[
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393103#comment-16393103
]
ASF GitHub Bot commented on SDAP-35:
------------------------------------
lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173496822
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/weblog/pre/SessionStatistic.java
##########
@@ -221,17 +221,17 @@ public int processSession(ESDriver es, String sessionId)
throws IOException, Int
request = matcher.group(1);
}
- String datasetlist = "/datasetlist?";
- String dataset = "/dataset/";
+ String datasetlist = props.getProperty(MudrodConstants.SEARCH_MARKER);
+ String dataset = props.getProperty(MudrodConstants.VIEW_MARKER);
if (request.contains(datasetlist)) {
searchDataListRequestCount++;
RequestUrl requestURL = new RequestUrl();
String infoStr = requestURL.getSearchInfo(request) + ",";
- String info = es.customAnalyzing(props.getProperty("indexName"),
infoStr);
+ String info =
es.customAnalyzing(props.getProperty(MudrodConstants.ES_INDEX_NAME), infoStr);
- if (!",".equals(info)) {
- if ("".equals(keywords)) {
+ if (!info.equals(",")) {
Review comment:
Move string value to right hand side of statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overhaul MUDROD configuration
> -----------------------------
>
> Key: SDAP-35
> URL: https://issues.apache.org/jira/browse/SDAP-35
> Project: Apache Science Data Analytics Platform
> Issue Type: Task
> Components: mudrod
> Reporter: Lewis John McGibbney
> Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create
> in JIRA. It makes things much easier as we try to improve the quality of our
> source code review and development workflow. Thank you
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
