[
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393104#comment-16393104
]
ASF GitHub Bot commented on SDAP-35:
------------------------------------
lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173496602
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/weblog/pre/ImportLogFile.java
##########
@@ -306,9 +306,9 @@ public void parseSingleLineHTTP(String log, String index,
String type) {
CrawlerDetection crawlerDe = new CrawlerDetection(this.props, this.es,
this.spark);
if (!crawlerDe.checkKnownCrawler(agent)) {
boolean tag = false;
- String[] mimeTypes = { ".js", ".css", ".jpg", ".png", ".ico",
"image_captcha", "autocomplete", ".gif", "/alldata/", "/api/", "get /
http/1.1", ".jpeg", "/ws/" };
- for (String mimeType : mimeTypes) {
- if (request.contains(mimeType)) {
+ String[] mimeTypes =
props.getProperty(MudrodConstants.BLACK_LIST_REQUEST).split(",");
+ for (int i = 0; i < mimeTypes.length; i++) {
Review comment:
If possible use enhanced for loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overhaul MUDROD configuration
> -----------------------------
>
> Key: SDAP-35
> URL: https://issues.apache.org/jira/browse/SDAP-35
> Project: Apache Science Data Analytics Platform
> Issue Type: Task
> Components: mudrod
> Reporter: Lewis John McGibbney
> Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create
> in JIRA. It makes things much easier as we try to improve the quality of our
> source code review and development workflow. Thank you
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
