[ 
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396957#comment-16396957
 ] 

ASF GitHub Bot commented on SDAP-35:
------------------------------------

Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD 
configuration
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r174137301
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/weblog/structure/ApacheAccessLog.java
 ##########
 @@ -15,55 +15,49 @@
 
 import com.google.gson.Gson;
 
+import org.apache.sdap.mudrod.main.MudrodConstants;
+import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
+
 import java.io.IOException;
 import java.io.Serializable;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Date;
+import java.util.Properties;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
-
 /**
  * This class represents an Apache access log line. See
  * http://httpd.apache.org/docs/2.2/logs.html for more details.
  */
 public class ApacheAccessLog extends WebLog implements Serializable {
-
-
-  /**
-   * 
-   */
-  private static final long serialVersionUID = 1L;
-
-  public ApacheAccessLog() {
-    //default constructor
-  }
-
-  String response;
-  String referer;
-  String browser;
+  String Response;
 
 Review comment:
   These variables were all upper case at the beginning. The previous 
enhancement PR changed it to lower case which can result in a null-pointer 
error, as they correspond to the field names in Elasticsearch which he didn't 
change. Therefore, I changed it back for the time being as these filed names 
are used explicitly at many places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Overhaul MUDROD configuration
> -----------------------------
>
>                 Key: SDAP-35
>                 URL: https://issues.apache.org/jira/browse/SDAP-35
>             Project: Apache Science Data Analytics Platform
>          Issue Type: Task
>          Components: mudrod
>            Reporter: Lewis John McGibbney
>            Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as 
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create 
> in JIRA. It makes things much easier as we try to improve the quality of our 
> source code review and development workflow. Thank you



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to