[ 
https://issues.apache.org/jira/browse/SDAP-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487510#comment-16487510
 ] 

ASF GitHub Bot commented on SDAP-75:
------------------------------------

lewismc commented on a change in pull request #22: SDAP-75
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/22#discussion_r190301999
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/ontology/process/OntologyLinkCal.java
 ##########
 @@ -91,6 +91,7 @@ public Object execute() {
       e.printStackTrace();
     } catch (InterruptedException e) {
       e.printStackTrace();
 
 Review comment:
   We should not be printing these stack traces, we should be logging them or 
re-throwing the exceptions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix bugs in AggregateTriples.java
> ---------------------------------
>
>                 Key: SDAP-75
>                 URL: https://issues.apache.org/jira/browse/SDAP-75
>             Project: Apache Science Data Analytics Platform
>          Issue Type: Bug
>          Components: mudrod
>            Reporter: Yun Li
>            Priority: Major
>             Fix For: 0.1
>
>
> Fix bugs found in AggregateTriple by sonar coverage @[~lewismc] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to