[
https://issues.apache.org/jira/browse/SDAP-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495245#comment-16495245
]
ASF GitHub Bot commented on SDAP-75:
------------------------------------
quintinali commented on a change in pull request #22: SDAP-75
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/22#discussion_r191793794
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/ontology/pre/AggregateTriples.java
##########
@@ -62,30 +62,28 @@ public Object execute() {
e2.printStackTrace();
}
- FileWriter fw;
- try {
- fw = new FileWriter(file.getAbsoluteFile());
+ try(FileWriter fw = new FileWriter(file.getAbsoluteFile())){
bw = new BufferedWriter(fw);
Review comment:
The ontology module is written by you and I'm not familiar with functions in
the class. I found bw is defined as a class variable and can't be pulled it
into the try-with-resource since bw is used in other functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix bugs in AggregateTriples.java
> ---------------------------------
>
> Key: SDAP-75
> URL: https://issues.apache.org/jira/browse/SDAP-75
> Project: Apache Science Data Analytics Platform
> Issue Type: Bug
> Components: mudrod
> Reporter: Yun Li
> Priority: Major
> Fix For: 0.1
>
>
> Fix bugs found in AggregateTriple by sonar coverage @[~lewismc]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
