RKuttruff commented on code in PR #282:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/282#discussion_r1336462012
##########
analysis/webservice/webmodel/NexusExecutionResults.py:
##########
@@ -53,6 +54,9 @@ def construct_done(status, created, completed, execution_id,
params, host):
params,
host
)
+ # Add stats to body
+ job_body['totalPrimaryMatched'] = num_primary_matched
+ job_body['averageSecondaryMatched'] =
round(num_secondary_matched/num_primary_matched)
Review Comment:
I'm curious why you decided to round to nearest int here. I think returning
this as a float could benefit by allowing the user to compute the number of
secondaries / total number of points more accurately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
