skorper commented on code in PR #282:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/282#discussion_r1336467124
##########
analysis/webservice/webmodel/NexusExecutionResults.py:
##########
@@ -53,6 +54,9 @@ def construct_done(status, created, completed, execution_id,
params, host):
params,
host
)
+ # Add stats to body
+ job_body['totalPrimaryMatched'] = num_primary_matched
+ job_body['averageSecondaryMatched'] =
round(num_secondary_matched/num_primary_matched)
Review Comment:
I'm open to your idea of not rounding. I added rounding because I wasn't
sure how valuable that extra info would be and I think it's nice that both
values are integers representing a count. Maybe we can see if the team has a
strong opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
