skorper commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511902837
########## pyproject.toml: ########## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +[tool.poetry] +name = "sdap-nexus" +version = "1.2.0" +description = "Nexus component for Apache SDAP" +authors = ["SDAP PPMC <dev@sdap.apache.org>"] +license = "Apache-2.0" +readme = "README.md" +packages = [ + { include = "webservice", from = "analysis" }, + { include = "nexustiles", from = "data-access" } +] +repository = "https://github.com/apache/incubator-sdap-nexus"; +exclude = ["docs", "tests"] +classifiers=[ + 'Development Status :: 6 - Mature', + 'Intended Audience :: Science/Research', + 'Operating System :: OS Independent', + 'Programming Language :: Python :: 3.8', + "License :: OSI Approved :: Apache Software License" +] + + +[tool.poetry.dependencies] +python = "~=3.8" +netcdf4 = "1.5.5.1" Review Comment: I noticed many of these are pinned to specific versions down to the patch level. Is there a reason for that? ########## docker/nexus-webapp/entrypoint.sh: ########## @@ -0,0 +1,133 @@ +#!/bin/bash Review Comment: I think we should remove this file as it will always be in the git history if we need to reference it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
