skorper commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977680451
> > What about the setup.py files, requirements.txt files, conda requirements files etc? Those are still in the repo currently. > > Also, what are your thoughts about packaging the analysis and data-access components together? I know Frank mentioned some counter arguments on dev@. > > I can delete those if necessary. > > By packaging them separately, I'm assuming you mean each would have its own pyproject.toml & poetry.lock? That seems like it'd be a bit excessive considering how closely related they are. I think doing it like this should be fine at least for now, considering how the architecture Frank mentioned doesn't really exist yet. Sounds good, I'm okay with that as well for now but we should definitely give Frank's comment more thought and consider moving in that direction in the future if it makes sense. I do think we should remove all requirements.txt, conda, and setup.py files now that we're using poetry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
