[ 
https://issues.apache.org/jira/browse/SEDONA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714935#comment-17714935
 ] 

Martin Andersson commented on SEDONA-276:
-----------------------------------------

[~kimahriman] That wasn't meant as criticism, sorry! So what you're saying is 
that we should move to slf4j for logging and use log4j config to silence noisy 
tests? Possibly we could add log4j2 as a test dependency for older versions of 
Spark until they are dropped. I think I read somewhere that Spark had supported 
log4j2 for a long time. They just didn't want to drop log4j1 since that would 
break all existing logging configurations. 

> Add support for Spark 3.4
> -------------------------
>
>                 Key: SEDONA-276
>                 URL: https://issues.apache.org/jira/browse/SEDONA-276
>             Project: Apache Sedona
>          Issue Type: Improvement
>            Reporter: Martin Andersson
>            Priority: Major
>
> Spark 3.4.0 was announced on April 14. 
> [https://lists.apache.org/thread/o1o9n1t036rmfp45q1jrjs0zzzx0j156]
> Findings from a quick test build using -Dspark.version=3.4.0:
>  # Incompatible logging api versions causes test failures.
>  # GeoParquet and Geotiff datasources fails to compile due to api changes in 
> Spark.
> Setting log4j and slf4j to the same versions as Spark 3.4.0 uses solves 1. I 
> don't know how that will affect other Spark versions.
> To solve 2 we might need to use reflection to handle the api changes in Spark.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to