----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45730/#review127059 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 926) <https://reviews.apache.org/r/45730/#comment190205> There is a subtle change here for getGroupNameRoleNamesMap. For databaseName == null and tableName == null case, getRoleNameTPrivilegesMap will still return some role set and this role set will be passed to getGroupNameRoleNamesMap. This will not be the same as we pass getGroupNameRoleNamesMap(null). While we may want getGroupNameRoleNamesMap(null) for databaseName == null and tableName == null case. - Jerry Chen On April 5, 2016, 7:30 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45730/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 7:30 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update Sentry Policy Service for export with specific auth object > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 73b0941 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > de50adb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > edc5661 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 8881d82 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > dbe4a27 > > Diff: https://reviews.apache.org/r/45730/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
