----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45730/#review127273 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 912) <https://reviews.apache.org/r/45730/#comment190499> The indent for new line for the same statement doesn't comply to the format style. I saw it is usually 4 spaces indent for statement with 2 or more lines. But here we saw 8 spaces. There are a lot of other instances. Please correct them too. - Jerry Chen On April 6, 2016, 2:38 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45730/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 2:38 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update Sentry Policy Service for export with specific auth object > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 73b0941 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > de50adb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > edc5661 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 8881d82 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 5b293ec > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > dbe4a27 > > Diff: https://reviews.apache.org/r/45730/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
